Cu2O and Ag-Cu2O nanoparticles were prepared via reflux method using EDTA. From the PXRD, FTIR, UV-DRS studies the synthesized NPs were characterized. The morphologies of the prepared NPs were studied by SEM and TEM analysis. The synthesized NPs were tested for photocatalytic and photoluminescence studies. The PXRD data indicated that the synthesized nanoparticles belong to cubic phase structure and space group Pn-3m. The SEM data revealed that cube like structure were obtained. Cu2O and Ag-Cu2O Nps were taken for determine the photocatalytic activity study on methylene blue dye, the results indicated that Ag-Cu2O NPs exhibited promising photocatalytic activity. This is due to occurrence of Ag particles on the Cu2O material, which makes the catalyst more sensitive. Furthermore, a photoluminescence study reveals that Cu2O and Ag-Cu2O nano particles shown yellow light emission. Copyright © VBRI Press.